Commit 502717f4 authored by Chen, Kenneth W's avatar Chen, Kenneth W Committed by Linus Torvalds
Browse files

[PATCH] hugetlb: fix linked list corruption in unmap_hugepage_range() 



commit fe1668ae causes kernel to oops with
libhugetlbfs test suite.  The problem is that hugetlb pages can be shared
by multiple mappings.  Multiple threads can fight over page->lru in the
unmap path and bad things happen.  We now serialize __unmap_hugepage_range
to void concurrent linked list manipulation.  Such serialization is also
needed for shared page table page on hugetlb area.  This patch will fixed
the bug and also serve as a prepatch for shared page table.

Signed-off-by: default avatarKen Chen <kenneth.w.chen@intel.com>
Cc: Hugh Dickins <hugh@veritas.com>
Cc: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 97c7801c

fs/hugetlbfs/inode.c

+1 −1
Original line number Diff line number Diff line
@@ -293,7 +293,7 @@ hugetlb_vmtruncate_list(struct prio_tree_root *root, unsigned long h_pgoff) 
		if (h_vm_pgoff >= h_pgoff)

			v_offset = 0;



		unmap_hugepage_range(vma,

		__unmap_hugepage_range(vma,

				vma->vm_start + v_offset, vma->vm_end);

	}

}

include/linux/hugetlb.h

+1 −0
Original line number Diff line number Diff line
@@ -17,6 +17,7 @@ int hugetlb_sysctl_handler(struct ctl_table *, int, struct file *, void __user * 
int copy_hugetlb_page_range(struct mm_struct *, struct mm_struct *, struct vm_area_struct *);

int follow_hugetlb_page(struct mm_struct *, struct vm_area_struct *, struct page **, struct vm_area_struct **, unsigned long *, int *, int);

void unmap_hugepage_range(struct vm_area_struct *, unsigned long, unsigned long);

void __unmap_hugepage_range(struct vm_area_struct *, unsigned long, unsigned long);

int hugetlb_prefault(struct address_space *, struct vm_area_struct *);

int hugetlb_report_meminfo(char *);

int hugetlb_report_node_meminfo(int, char *);

mm/hugetlb.c

+20 −2
Original line number Diff line number Diff line
@@ -356,7 +356,7 @@ nomem: 
	return -ENOMEM;

}



void unmap_hugepage_range(struct vm_area_struct *vma, unsigned long start,

void __unmap_hugepage_range(struct vm_area_struct *vma, unsigned long start,

			    unsigned long end)

{

	struct mm_struct *mm = vma->vm_mm;
@@ -398,6 +398,24 @@ void unmap_hugepage_range(struct vm_area_struct *vma, unsigned long start, 
	}

}



void unmap_hugepage_range(struct vm_area_struct *vma, unsigned long start,

			  unsigned long end)

{

	/*

	 * It is undesirable to test vma->vm_file as it should be non-null

	 * for valid hugetlb area. However, vm_file will be NULL in the error

	 * cleanup path of do_mmap_pgoff. When hugetlbfs ->mmap method fails,

	 * do_mmap_pgoff() nullifies vma->vm_file before calling this function

	 * to clean up. Since no pte has actually been setup, it is safe to

	 * do nothing in this case.

	 */

	if (vma->vm_file) {

		spin_lock(&vma->vm_file->f_mapping->i_mmap_lock);

		__unmap_hugepage_range(vma, start, end);

		spin_unlock(&vma->vm_file->f_mapping->i_mmap_lock);

	}

}



static int hugetlb_cow(struct mm_struct *mm, struct vm_area_struct *vma,

			unsigned long address, pte_t *ptep, pte_t pte)

{

CRA Git | Maintained and supported by SUSTech CRA and CCSE