Commit 500f36a4 authored Sep 16, 2019 by Tariq Toukan Committed by Saeed Mahameed Oct 18, 2019

net/mlx5e: Tx, Zero-memset WQE info struct upon update



Not all fields of WQE info are being written in the function,
having some leftovers from previous rounds.
Zero-memset it upon update.

Particularly, not nullifying the wi->resync_dump_frag field
will cause double free of the kTLS DUMPed frags.

Fixes: d2ead1f3 ("net/mlx5e: Add kTLS TX HW offload support")
Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
Reviewed-by: Eran Ben Elisha <eranbe@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>

parent 0c258dec

drivers/net/ethernet/mellanox/mlx5/core/en/txrx.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -92,7 +92,7 @@ mlx5e_fill_sq_frag_edge(struct mlx5e_txqsq sq, struct mlx5_wq_cyc wq,

		/* fill sq frag edge with nops to avoid wqe wrapping two pages */
		for (; wi < edge_wi; wi++) {
		wi->skb = NULL;
		memset(wi, 0, sizeof(*wi));
		wi->num_wqebbs = 1;
		mlx5e_post_nop(wq, sq->sqn, &sq->pc);
		}

Admin message