Commit 500e69a1 authored by Lee Jones's avatar Lee Jones
Browse files

mfd: ab8500-core: Fix many warnings reported by Checkpatch 



WARNING: Block comments use a trailing */ on a separate line
+        * */

WARNING: Block comments use a trailing */ on a separate line
+        * bank on higher 8 bits and reg in lower */

WARNING: Block comments use a trailing */ on a separate line
+        * bank on higher 8 bits and reg in lower */

WARNING: suspect code indent for conditional statements (8, 24)
+       if (unlikely(*offset == 17))
+                       *offset = 24;

WARNING: suspect code indent for conditional statements (8, 24)
+       if (unlikely(*offset == 16))
+                       *offset = 25;

WARNING: suspect code indent for conditional statements (8, 24)
+       if ((i == 3) && (*offset >= 24))
+                       *offset += 2;

WARNING: ENOSYS means 'invalid syscall nr' and nothing else
+               return -ENOSYS;

WARNING: static const char * array should probably be static const char * const
+       static const char *switch_off_status[] = {

WARNING: static const char * array should probably be static const char * const
+       static const char *turn_on_status[] = {

total: 0 errors, 9 warnings, 1867 lines checked

Cc: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent 845b76f8

drivers/mfd/ab8500-core.c

+10 −14
Original line number Diff line number Diff line
@@ -211,7 +211,7 @@ static int set_register_interruptible(struct ab8500 *ab8500, u8 bank, 
	/*

	 * Put the u8 bank and u8 register together into a an u16.

	 * The bank on higher 8 bits and register in lower 8 bits.

	 * */

	 */

	u16 addr = ((u16)bank) << 8 | reg;



	dev_vdbg(ab8500->dev, "wr: addr %#x <= %#x\n", addr, data);
@@ -243,8 +243,6 @@ static int get_register_interruptible(struct ab8500 *ab8500, u8 bank, 
	u8 reg, u8 *value)

{

	int ret;

	/* put the u8 bank and u8 reg together into a an u16.

	 * bank on higher 8 bits and reg in lower */

	u16 addr = ((u16)bank) << 8 | reg;



	mutex_lock(&ab8500->lock);
@@ -278,8 +276,6 @@ static int mask_and_set_register_interruptible(struct ab8500 *ab8500, u8 bank, 
	u8 reg, u8 bitmask, u8 bitvalues)

{

	int ret;

	/* put the u8 bank and u8 reg together into a an u16.

	 * bank on higher 8 bits and reg in lower */

	u16 addr = ((u16)bank) << 8 | reg;



	mutex_lock(&ab8500->lock);
@@ -595,7 +591,7 @@ static int ab8500_irq_init(struct ab8500 *ab8500, struct device_node *np) 


	if (!ab8500->domain) {

		dev_err(ab8500->dev, "Failed to create irqdomain\n");

		return -ENOSYS;

		return -ENODEV;

	}



	return 0;
@@ -1073,7 +1069,7 @@ static struct attribute_group ab9540_attr_group = { 


static int ab8500_probe(struct platform_device *pdev)

{

	static const char *switch_off_status[] = {

	static const char * const switch_off_status[] = {

		"Swoff bit programming",

		"Thermal protection activation",

		"Vbat lower then BattOk falling threshold",
@@ -1082,7 +1078,7 @@ static int ab8500_probe(struct platform_device *pdev) 
		"Battery level lower than power on reset threshold",

		"Power on key 1 pressed longer than 10 seconds",

		"DB8500 thermal shutdown"};

	static const char *turn_on_status[] = {

	static const char * const turn_on_status[] = {

		"Battery rising (Vbat)",

		"Power On Key 1 dbF",

		"Power On Key 2 dbF",

CRA Git | Maintained and supported by SUSTech CRA and CCSE