Commit 4ff96fb5 authored Jul 19, 2019 by Miroslav Benes Committed by Petr Mladek Aug 19, 2019

livepatch: Nullify obj->mod in klp_module_coming()'s error path



klp_module_coming() is called for every module appearing in the system.
It sets obj->mod to a patched module for klp_object obj. Unfortunately
it leaves it set even if an error happens later in the function and the
patched module is not allowed to be loaded.

klp_is_object_loaded() uses obj->mod variable and could currently give a
wrong return value. The bug is probably harmless as of now.

Signed-off-by: Miroslav Benes <mbenes@suse.cz>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Petr Mladek <pmladek@suse.com>

parent db045733

kernel/livepatch/core.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1175,6 +1175,7 @@ err:
		pr_warn("patch '%s' failed for module '%s', refusing to load module '%s'\n",
		patch->mod->name, obj->mod->name, obj->mod->name);
		mod->klp_alive = false;
		obj->mod = NULL;
		klp_cleanup_module_patches_limited(mod, patch);
		mutex_unlock(&klp_mutex);

Admin message