Commit 4fd9ac6b authored Aug 23, 2020 by Dinghao Liu Committed by Andy Shevchenko Sep 24, 2020

Platform: OLPC: Fix memleak in olpc_ec_probe



When devm_regulator_register() fails, ec should be
freed just like when olpc_ec_cmd() fails.

Fixes: 231c0c21 ("Platform: OLPC: Add a regulator for the DCON")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

parent 9123e3a7

drivers/platform/olpc/olpc-ec.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -439,7 +439,9 @@ static int olpc_ec_probe(struct platform_device *pdev)
		&config);
		if (IS_ERR(ec->dcon_rdev)) {
		dev_err(&pdev->dev, "failed to register DCON regulator\n");
		return PTR_ERR(ec->dcon_rdev);
		err = PTR_ERR(ec->dcon_rdev);
		kfree(ec);
		return err;
		}

		ec->dbgfs_dir = olpc_ec_setup_debugfs();

Admin message