drm/amd/display: program manual trigger only for bottom most pipe (4fd33412) · Commits · 戴 / test

[Why] We only want to manual trigger end-of-frame when the bottom-most pipe is flipped to prevent overlays from ending the frame too early. [How] Check that the manual trigger is only firing on bottom plane. Signed-off-by:

Aric Cyr <aric.cyr@amd.com> Reviewed-by:

Jun Lei <Jun.Lei@amd.com> Acked-by:

Leo Li <sunpeng.li@amd.com> Signed-off-by:

Alex Deucher <alexander.deucher@amd.com>

drivers/gpu/drm/amd/display/dc/core/dc.c

+7 −7

Original line number	Diff line number	Diff line
		@@ -1781,14 +1781,14 @@ static void commit_planes_for_stream(struct dc *dc,
		dc->hwss.pipe_control_lock(dc, top_pipe_to_program, false);
		}

		// Fire manual trigger
		for (i = 0; i < dc->res_pool->pipe_count; i++) {
		struct pipe_ctx *pipe_ctx = &context->res_ctx.pipe_ctx[i];
		// Fire manual trigger only when bottom plane is flipped
		for (j = 0; j < dc->res_pool->pipe_count; j++) {
		struct pipe_ctx *pipe_ctx = &context->res_ctx.pipe_ctx[j];

		if (pipe_ctx->top_pipe \|\|
		if (pipe_ctx->bottom_pipe \|\|
		!pipe_ctx->stream \|\|
		pipe_ctx->stream != stream \|\|
		!srf_updates[i].flip_addr)
		!pipe_ctx->plane_state->update_flags.bits.addr_update)
		continue;

		if (pipe_ctx->stream_res.tg->funcs->program_manual_trigger)

Admin message