fsi: sbefifo: Fix inconsistent use of ffdc mutex (4fcdc2d1) · Commits · 戴 / test

drivers/fsi/fsi-sbefifo.c

+9 −4

Original line number	Diff line number	Diff line
		@@ -136,8 +136,7 @@ struct sbefifo_user {
		static DEFINE_IDA(sbefifo_ida);
		static DEFINE_MUTEX(sbefifo_ffdc_mutex);


		static void sbefifo_dump_ffdc(struct device dev, const __be32 ffdc,
		static void __sbefifo_dump_ffdc(struct device dev, const __be32 ffdc,
		size_t ffdc_sz, bool internal)
		{
		int pack = 0;
		@@ -145,7 +144,6 @@ static void sbefifo_dump_ffdc(struct device dev, const __be32 ffdc,
		static char ffdc_line[FFDC_LSIZE];
		char *p = ffdc_line;

		mutex_lock(&sbefifo_ffdc_mutex);
		while (ffdc_sz) {
		u32 w0, w1, w2, i;
		if (ffdc_sz < 3) {
		@@ -194,6 +192,13 @@ static void sbefifo_dump_ffdc(struct device dev, const __be32 ffdc,
		}
		dev_warn(dev, "+-------------------------------------------+\n");
		}
		}

		static void sbefifo_dump_ffdc(struct device dev, const __be32 ffdc,
		size_t ffdc_sz, bool internal)
		{
		mutex_lock(&sbefifo_ffdc_mutex);
		__sbefifo_dump_ffdc(dev, ffdc, ffdc_sz, internal);
		mutex_unlock(&sbefifo_ffdc_mutex);
		}