Commit 4fb28474 authored by Kirill A. Shutemov's avatar Kirill A. Shutemov Committed by Russell King
Browse files

ARM: 5727/1: Pass IFSR register to do_PrefetchAbort() 



Instruction fault status register, IFSR, was introduced on ARMv6 to
provide status information about the last insturction fault. It
needed for proper prefetch abort handling.

Now we have three prefetch abort model:

  * legacy - for CPUs before ARMv6. They doesn't provide neither
    IFSR nor IFAR. We simulate IFSR with section translation fault
    status for them to generalize code;
  * ARMv6 - provides IFSR, but not IFAR;
  * ARMv7 - provides both IFSR and IFAR.

Signed-off-by: default avatarKirill A. Shutemov <kirill@shutemov.name>
Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
parent 6806bfe1

arch/arm/include/asm/glue.h

+20 −6
Original line number Diff line number Diff line
@@ -120,25 +120,39 @@ 
#endif



/*

 * Prefetch abort handler.  If the CPU has an IFAR use that, otherwise

 * use the address of the aborted instruction

 *	Prefetch Abort Model

 *	================

 *

 *	We have the following to choose from:

 *	  legacy	- no IFSR, no IFAR

 *	  v6		- ARMv6: IFSR, no IFAR

 *	  v7		- ARMv7: IFSR and IFAR

 */



#undef CPU_PABORT_HANDLER

#undef MULTI_PABORT



#ifdef CONFIG_CPU_PABRT_IFAR

#ifdef CONFIG_CPU_PABRT_LEGACY

# ifdef CPU_PABORT_HANDLER

#  define MULTI_PABORT 1

# else

#  define CPU_PABORT_HANDLER legacy_pabort

# endif

#endif



#ifdef CONFIG_CPU_PABRT_V6

# ifdef CPU_PABORT_HANDLER

#  define MULTI_PABORT 1

# else

#  define CPU_PABORT_HANDLER(reg, insn)	mrc p15, 0, reg, cr6, cr0, 2

#  define CPU_PABORT_HANDLER v6_pabort

# endif

#endif



#ifdef CONFIG_CPU_PABRT_NOIFAR

#ifdef CONFIG_CPU_PABRT_V7

# ifdef CPU_PABORT_HANDLER

#  define MULTI_PABORT 1

# else

#  define CPU_PABORT_HANDLER(reg, insn)	mov reg, insn

#  define CPU_PABORT_HANDLER v7_pabort

# endif

#endif

arch/arm/kernel/entry-armv.S

+6 −12
Original line number Diff line number Diff line
@@ -311,22 +311,16 @@ __pabt_svc: 
	tst	r3, #PSR_I_BIT

	biceq	r9, r9, #PSR_I_BIT



	@

	@ set args, then call main handler

	@

	@  r0 - address of faulting instruction

	@  r1 - pointer to registers on stack

	@

#ifdef MULTI_PABORT

	mov	r0, r2			@ pass address of aborted instruction.

#ifdef MULTI_PABORT

	ldr	r4, .LCprocfns

	mov	lr, pc

	ldr	pc, [r4, #PROCESSOR_PABT_FUNC]

#else

	CPU_PABORT_HANDLER(r0, r2)

	bl	CPU_PABORT_HANDLER

#endif

	msr	cpsr_c, r9			@ Maybe enable interrupts

	mov	r1, sp				@ regs

	mov	r2, sp				@ regs

	bl	do_PrefetchAbort		@ call abort handler



	@
@@ -701,16 +695,16 @@ ENDPROC(__und_usr_unknown) 
__pabt_usr:

	usr_entry



#ifdef MULTI_PABORT

	mov	r0, r2			@ pass address of aborted instruction.

#ifdef MULTI_PABORT

	ldr	r4, .LCprocfns

	mov	lr, pc

	ldr	pc, [r4, #PROCESSOR_PABT_FUNC]

#else

	CPU_PABORT_HANDLER(r0, r2)

	bl	CPU_PABORT_HANDLER

#endif

	enable_irq				@ Enable interrupts

	mov	r1, sp				@ regs

	mov	r2, sp				@ regs

	bl	do_PrefetchAbort		@ call abort handler

 UNWIND(.fnend		)

	/* fall through */

arch/arm/kernel/entry-common.S

+0 −7
Original line number Diff line number Diff line
@@ -425,13 +425,6 @@ sys_mmap2: 
#endif

ENDPROC(sys_mmap2)



ENTRY(pabort_ifar)

		mrc	p15, 0, r0, cr6, cr0, 2

ENTRY(pabort_noifar)

		mov	pc, lr

ENDPROC(pabort_ifar)

ENDPROC(pabort_noifar)



#ifdef CONFIG_OABI_COMPAT



/*

arch/arm/mm/Kconfig

+30 −27
Original line number Diff line number Diff line
@@ -17,7 +17,7 @@ config CPU_ARM610 
	select CPU_CP15_MMU

	select CPU_COPY_V3 if MMU

	select CPU_TLB_V3 if MMU

	select CPU_PABRT_NOIFAR

	select CPU_PABRT_LEGACY

	help

	  The ARM610 is the successor to the ARM3 processor

	  and was produced by VLSI Technology Inc.
@@ -31,7 +31,7 @@ config CPU_ARM7TDMI 
	depends on !MMU

	select CPU_32v4T

	select CPU_ABRT_LV4T

	select CPU_PABRT_NOIFAR

	select CPU_PABRT_LEGACY

	select CPU_CACHE_V4

	help

	  A 32-bit RISC microprocessor based on the ARM7 processor core
@@ -49,7 +49,7 @@ config CPU_ARM710 
	select CPU_CP15_MMU

	select CPU_COPY_V3 if MMU

	select CPU_TLB_V3 if MMU

	select CPU_PABRT_NOIFAR

	select CPU_PABRT_LEGACY

	help

	  A 32-bit RISC microprocessor based on the ARM7 processor core

	  designed by Advanced RISC Machines Ltd. The ARM710 is the
@@ -64,7 +64,7 @@ config CPU_ARM720T 
	bool "Support ARM720T processor" if ARCH_INTEGRATOR

	select CPU_32v4T

	select CPU_ABRT_LV4T

	select CPU_PABRT_NOIFAR

	select CPU_PABRT_LEGACY

	select CPU_CACHE_V4

	select CPU_CACHE_VIVT

	select CPU_CP15_MMU
@@ -83,7 +83,7 @@ config CPU_ARM740T 
	depends on !MMU

	select CPU_32v4T

	select CPU_ABRT_LV4T

	select CPU_PABRT_NOIFAR

	select CPU_PABRT_LEGACY

	select CPU_CACHE_V3	# although the core is v4t

	select CPU_CP15_MPU

	help
@@ -100,7 +100,7 @@ config CPU_ARM9TDMI 
	depends on !MMU

	select CPU_32v4T

	select CPU_ABRT_NOMMU

	select CPU_PABRT_NOIFAR

	select CPU_PABRT_LEGACY

	select CPU_CACHE_V4

	help

	  A 32-bit RISC microprocessor based on the ARM9 processor core
@@ -114,7 +114,7 @@ config CPU_ARM920T 
	bool "Support ARM920T processor" if ARCH_INTEGRATOR

	select CPU_32v4T

	select CPU_ABRT_EV4T

	select CPU_PABRT_NOIFAR

	select CPU_PABRT_LEGACY

	select CPU_CACHE_V4WT

	select CPU_CACHE_VIVT

	select CPU_CP15_MMU
@@ -135,7 +135,7 @@ config CPU_ARM922T 
	bool "Support ARM922T processor" if ARCH_INTEGRATOR

	select CPU_32v4T

	select CPU_ABRT_EV4T

	select CPU_PABRT_NOIFAR

	select CPU_PABRT_LEGACY

	select CPU_CACHE_V4WT

	select CPU_CACHE_VIVT

	select CPU_CP15_MMU
@@ -154,7 +154,7 @@ config CPU_ARM925T 
 	bool "Support ARM925T processor" if ARCH_OMAP1

	select CPU_32v4T

	select CPU_ABRT_EV4T

	select CPU_PABRT_NOIFAR

	select CPU_PABRT_LEGACY

	select CPU_CACHE_V4WT

	select CPU_CACHE_VIVT

	select CPU_CP15_MMU
@@ -173,7 +173,7 @@ config CPU_ARM926T 
	bool "Support ARM926T processor" if ARCH_INTEGRATOR || MACH_REALVIEW_EB

	select CPU_32v5

	select CPU_ABRT_EV5TJ

	select CPU_PABRT_NOIFAR

	select CPU_PABRT_LEGACY

	select CPU_CACHE_VIVT

	select CPU_CP15_MMU

	select CPU_COPY_V4WB if MMU
@@ -191,7 +191,7 @@ config CPU_FA526 
	bool

	select CPU_32v4

	select CPU_ABRT_EV4

	select CPU_PABRT_NOIFAR

	select CPU_PABRT_LEGACY

	select CPU_CACHE_VIVT

	select CPU_CP15_MMU

	select CPU_CACHE_FA
@@ -210,7 +210,7 @@ config CPU_ARM940T 
	depends on !MMU

	select CPU_32v4T

	select CPU_ABRT_NOMMU

	select CPU_PABRT_NOIFAR

	select CPU_PABRT_LEGACY

	select CPU_CACHE_VIVT

	select CPU_CP15_MPU

	help
@@ -228,7 +228,7 @@ config CPU_ARM946E 
	depends on !MMU

	select CPU_32v5

	select CPU_ABRT_NOMMU

	select CPU_PABRT_NOIFAR

	select CPU_PABRT_LEGACY

	select CPU_CACHE_VIVT

	select CPU_CP15_MPU

	help
@@ -244,7 +244,7 @@ config CPU_ARM1020 
	bool "Support ARM1020T (rev 0) processor" if ARCH_INTEGRATOR

	select CPU_32v5

	select CPU_ABRT_EV4T

	select CPU_PABRT_NOIFAR

	select CPU_PABRT_LEGACY

	select CPU_CACHE_V4WT

	select CPU_CACHE_VIVT

	select CPU_CP15_MMU
@@ -262,7 +262,7 @@ config CPU_ARM1020E 
	bool "Support ARM1020E processor" if ARCH_INTEGRATOR

	select CPU_32v5

	select CPU_ABRT_EV4T

	select CPU_PABRT_NOIFAR

	select CPU_PABRT_LEGACY

	select CPU_CACHE_V4WT

	select CPU_CACHE_VIVT

	select CPU_CP15_MMU
@@ -275,7 +275,7 @@ config CPU_ARM1022 
	bool "Support ARM1022E processor" if ARCH_INTEGRATOR

	select CPU_32v5

	select CPU_ABRT_EV4T

	select CPU_PABRT_NOIFAR

	select CPU_PABRT_LEGACY

	select CPU_CACHE_VIVT

	select CPU_CP15_MMU

	select CPU_COPY_V4WB if MMU # can probably do better
@@ -293,7 +293,7 @@ config CPU_ARM1026 
	bool "Support ARM1026EJ-S processor" if ARCH_INTEGRATOR

	select CPU_32v5

	select CPU_ABRT_EV5T # But need Jazelle, but EV5TJ ignores bit 10

	select CPU_PABRT_NOIFAR

	select CPU_PABRT_LEGACY

	select CPU_CACHE_VIVT

	select CPU_CP15_MMU

	select CPU_COPY_V4WB if MMU # can probably do better
@@ -311,7 +311,7 @@ config CPU_SA110 
	select CPU_32v3 if ARCH_RPC

	select CPU_32v4 if !ARCH_RPC

	select CPU_ABRT_EV4

	select CPU_PABRT_NOIFAR

	select CPU_PABRT_LEGACY

	select CPU_CACHE_V4WB

	select CPU_CACHE_VIVT

	select CPU_CP15_MMU
@@ -331,7 +331,7 @@ config CPU_SA1100 
	bool

	select CPU_32v4

	select CPU_ABRT_EV4

	select CPU_PABRT_NOIFAR

	select CPU_PABRT_LEGACY

	select CPU_CACHE_V4WB

	select CPU_CACHE_VIVT

	select CPU_CP15_MMU
@@ -342,7 +342,7 @@ config CPU_XSCALE 
	bool

	select CPU_32v5

	select CPU_ABRT_EV5T

	select CPU_PABRT_NOIFAR

	select CPU_PABRT_LEGACY

	select CPU_CACHE_VIVT

	select CPU_CP15_MMU

	select CPU_TLB_V4WBI if MMU
@@ -352,7 +352,7 @@ config CPU_XSC3 
	bool

	select CPU_32v5

	select CPU_ABRT_EV5T

	select CPU_PABRT_NOIFAR

	select CPU_PABRT_LEGACY

	select CPU_CACHE_VIVT

	select CPU_CP15_MMU

	select CPU_TLB_V4WBI if MMU
@@ -363,7 +363,7 @@ config CPU_MOHAWK 
	bool

	select CPU_32v5

	select CPU_ABRT_EV5T

	select CPU_PABRT_NOIFAR

	select CPU_PABRT_LEGACY

	select CPU_CACHE_VIVT

	select CPU_CP15_MMU

	select CPU_TLB_V4WBI if MMU
@@ -374,7 +374,7 @@ config CPU_FEROCEON 
	bool

	select CPU_32v5

	select CPU_ABRT_EV5T

	select CPU_PABRT_NOIFAR

	select CPU_PABRT_LEGACY

	select CPU_CACHE_VIVT

	select CPU_CP15_MMU

	select CPU_COPY_FEROCEON if MMU
@@ -394,7 +394,7 @@ config CPU_V6 
	bool "Support ARM V6 processor" if ARCH_INTEGRATOR || MACH_REALVIEW_EB || MACH_REALVIEW_PBX

	select CPU_32v6

	select CPU_ABRT_EV6

	select CPU_PABRT_NOIFAR

	select CPU_PABRT_V6

	select CPU_CACHE_V6

	select CPU_CACHE_VIPT

	select CPU_CP15_MMU
@@ -420,7 +420,7 @@ config CPU_V7 
	select CPU_32v6K

	select CPU_32v7

	select CPU_ABRT_EV7

	select CPU_PABRT_IFAR

	select CPU_PABRT_V7

	select CPU_CACHE_V7

	select CPU_CACHE_VIPT

	select CPU_CP15_MMU
@@ -482,10 +482,13 @@ config CPU_ABRT_EV6 
config CPU_ABRT_EV7

	bool



config CPU_PABRT_IFAR

config CPU_PABRT_LEGACY

	bool



config CPU_PABRT_NOIFAR

config CPU_PABRT_V6

	bool



config CPU_PABRT_V7

	bool



# The cache model

arch/arm/mm/Makefile

+4 −0
Original line number Diff line number Diff line
@@ -27,6 +27,10 @@ obj-$(CONFIG_CPU_ABRT_EV5TJ) += abort-ev5tj.o 
obj-$(CONFIG_CPU_ABRT_EV6)	+= abort-ev6.o

obj-$(CONFIG_CPU_ABRT_EV7)	+= abort-ev7.o



obj-$(CONFIG_CPU_PABRT_LEGACY)	+= pabort-legacy.o

obj-$(CONFIG_CPU_PABRT_V6)	+= pabort-v6.o

obj-$(CONFIG_CPU_PABRT_V7)	+= pabort-v7.o



obj-$(CONFIG_CPU_CACHE_V3)	+= cache-v3.o

obj-$(CONFIG_CPU_CACHE_V4)	+= cache-v4.o

obj-$(CONFIG_CPU_CACHE_V4WT)	+= cache-v4wt.o

CRA Git | Maintained and supported by SUSTech CRA and CCSE