Commit 4f967f6d authored Nov 23, 2016 by Roderick Colenbrander Committed by Jiri Kosina Nov 28, 2016

HID: sony: Fix memory issue when connecting device using both Bluetooth and USB

A previous patch moved most input initialization from sony_probe to
sony_input_configured to avoid some race conditions. The driver has some
special logic to prevent the device to get registered twice in case the
user connects it both over Bluetooth and USB. When this condition
happens sony_input_configured returns a failure, but sony_probe continues
as hid_hw_start doesn't fail. As was discussed on linux-input, it is
acceptable for this function to fail.

This patch adds a check for the HID_CLAIMED_INPUT flag within sony_probe
to determine whether initialization succeeded correctly. The flag is
not set by the HID layer when sony_input_configured fails.

Signed-off-by: Roderick Colenbrander <roderick.colenbrander@sony.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

parent cf1015d6

drivers/hid/hid-sony.c

+13 −0

Original line number	Diff line number	Diff line
		@@ -2524,6 +2524,19 @@ static int sony_probe(struct hid_device hdev, const struct hid_device_id id)
		return ret;
		}

		/* sony_input_configured can fail, but this doesn't result
		* in hid_hw_start failures (intended). Check whether
		* the HID layer claimed the device else fail.
		* We don't know the actual reason for the failure, most
		* likely it is due to EEXIST in case of double connection
		* of USB and Bluetooth, but could have been due to ENOMEM
		* or other reasons as well.
		*/
		if (!(hdev->claimed & HID_CLAIMED_INPUT)) {
		hid_err(hdev, "failed to claim input\n");
		return -ENODEV;
		}

		return ret;
		}

Admin message