ipr: Don't set NO_ULEN_CHK bit when resource is a vset. (4f92d01a) · Commits · 戴 / test

According to the IPR specification, Inhibit Underlength Checking bit must be disabled when issuing commands to vsets. Enabling it in this case might cause SCSI commands to fail with an Illegal Request, so make sure we keep this bit cleared when resource is a vset. Signed-off-by:

Gabriel Krisman Bertazi <krisman@linux.vnet.ibm.com> Reviewed-by:

Manoj Kumar <manoj@linux.vnet.ibm.com> Acked-by:

Brian King <brking@linux.vnet.ibm.com> Reviewed-by:

Wen Xiong <wenxiong@linux.vnet.ibm.com> Signed-off-by:

Martin K. Petersen <martin.petersen@oracle.com>

drivers/scsi/ipr.c

+7 −3

Original line number	Diff line number	Diff line
		@@ -6363,15 +6363,19 @@ static int ipr_queuecommand(struct Scsi_Host *shost,
		ipr_cmd->scsi_cmd = scsi_cmd;
		ipr_cmd->done = ipr_scsi_eh_done;

		if (ipr_is_gscsi(res) \|\| ipr_is_vset_device(res)) {
		if (ipr_is_gscsi(res)) {
		if (scsi_cmd->underflow == 0)
		ioarcb->cmd_pkt.flags_hi \|= IPR_FLAGS_HI_NO_ULEN_CHK;

		ioarcb->cmd_pkt.flags_hi \|= IPR_FLAGS_HI_NO_LINK_DESC;
		if (ipr_is_gscsi(res) && res->reset_occurred) {
		if (res->reset_occurred) {
		res->reset_occurred = 0;
		ioarcb->cmd_pkt.flags_lo \|= IPR_FLAGS_LO_DELAY_AFTER_RST;
		}
		}

		if (ipr_is_gscsi(res) \|\| ipr_is_vset_device(res)) {
		ioarcb->cmd_pkt.flags_hi \|= IPR_FLAGS_HI_NO_LINK_DESC;

		ioarcb->cmd_pkt.flags_lo \|= IPR_FLAGS_LO_ALIGNED_BFR;
		if (scsi_cmd->flags & SCMD_TAGGED)
		ioarcb->cmd_pkt.flags_lo \|= IPR_FLAGS_LO_SIMPLE_TASK;

Admin message