Commit 4f84b383 authored Aug 12, 2019 by Nick Desaulniers Committed by Vasily Gorbik Oct 31, 2019

s390/boot: fix section name escaping



GCC unescapes escaped string section names while Clang does not. Because
__section uses the `#` stringification operator for the section name, it
doesn't need to be escaped.

This antipattern was found with:
$ grep -e __section\(\" -e __section__\(\" -r

Reported-by: Sedat Dilek <sedat.dilek@gmail.com>
Suggested-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Message-Id: <20190812215052.71840-1-ndesaulniers@google.com>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>

parent cceb0183

arch/s390/boot/startup.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -46,7 +46,7 @@ struct diag_ops __bootdata_preserved(diag_dma_ops) = {
		.diag0c = _diag0c_dma,
		.diag308_reset = _diag308_reset_dma
		};
		static struct diag210 _diag210_tmp_dma __section(".dma.data");
		static struct diag210 _diag210_tmp_dma __section(.dma.data);
		struct diag210 *__bootdata_preserved(__diag210_tmp_dma) = &_diag210_tmp_dma;
		void _swsusp_reset_dma(void);
		unsigned long __bootdata_preserved(__swsusp_reset_dma) = __pa(_swsusp_reset_dma);

Admin message