Commit 4f78d91c authored by Dmitry Torokhov's avatar Dmitry Torokhov Committed by Linus Walleij
Browse files

gpiolib: acpi: make acpi_can_fallback_to_crs() static 



It is not used outside gpiolib-acpi.c module, so there is no need to
export it.

Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
Link: https://lore.kernel.org/r/20190904172624.GA76617@dtor-ws


Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 6babaaeb

drivers/gpio/gpiolib-acpi.c

+10 −9
Original line number Diff line number Diff line
@@ -728,6 +728,16 @@ static struct gpio_desc *acpi_get_gpiod_by_index(struct acpi_device *adev, 
	return ret ? ERR_PTR(ret) : lookup.desc;

}



static bool acpi_can_fallback_to_crs(struct acpi_device *adev,

				     const char *con_id)

{

	/* Never allow fallback if the device has properties */

	if (acpi_dev_has_props(adev) || adev->driver_gpios)

		return false;



	return con_id == NULL;

}



struct gpio_desc *acpi_find_gpio(struct device *dev,

				 const char *con_id,

				 unsigned int idx,
@@ -1264,15 +1274,6 @@ int acpi_gpio_count(struct device *dev, const char *con_id) 
	return count ? count : -ENOENT;

}



bool acpi_can_fallback_to_crs(struct acpi_device *adev, const char *con_id)

{

	/* Never allow fallback if the device has properties */

	if (acpi_dev_has_props(adev) || adev->driver_gpios)

		return false;



	return con_id == NULL;

}



/* Run deferred acpi_gpiochip_request_irqs() */

static int acpi_gpio_handle_deferred_request_irqs(void)

{

drivers/gpio/gpiolib-acpi.h

+0 −8
Original line number Diff line number Diff line
@@ -52,8 +52,6 @@ struct gpio_desc *acpi_node_get_gpiod(struct fwnode_handle *fwnode, 
				      struct acpi_gpio_info *info);



int acpi_gpio_count(struct device *dev, const char *con_id);



bool acpi_can_fallback_to_crs(struct acpi_device *adev, const char *con_id);

#else

static inline void acpi_gpiochip_add(struct gpio_chip *chip) { }

static inline void acpi_gpiochip_remove(struct gpio_chip *chip) { }
@@ -93,12 +91,6 @@ static inline int acpi_gpio_count(struct device *dev, const char *con_id) 
{

	return -ENODEV;

}



static inline bool acpi_can_fallback_to_crs(struct acpi_device *adev,

					    const char *con_id)

{

	return false;

}

#endif



#endif /* GPIOLIB_ACPI_H */

CRA Git | Maintained and supported by SUSTech CRA and CCSE