Commit 4f4139e0 authored Aug 06, 2019 by Merwin Trever Ferrao Committed by Greg Kroah-Hartman Aug 08, 2019

Staging: rtl8188eu: core: rtw_security: tidy up crc32_init()



This code generates checkpatch warning:

WARNING: else is not generally useful after a break or return

Moving the declaration to the top of the function we can pull the
code back one tab and it makes it more readable.

Signed-off-by: Merwin Trever Ferrao <merwintf@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20190806122849.GA25628@IoT-COE


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent b0d525a0

drivers/staging/rtl8188eu/core/rtw_security.c

+20 −21

Original line number	Diff line number	Diff line
		@@ -87,14 +87,14 @@ static u8 crc32_reverseBit(u8 data)

		static void crc32_init(void)
		{
		if (bcrc32initialized == 1) {
		return;
		} else {
		int i, j;
		u32 c;
		u8 p = (u8 )&c, *p1;
		u8 k;

		if (bcrc32initialized == 1)
		return;

		c = 0x12340000;

		for (i = 0; i < 256; ++i) {
		@@ -110,7 +110,6 @@ static void crc32_init(void)
		}
		bcrc32initialized = 1;
		}
		}

		static __le32 getcrc32(u8 *buf, int len)
		{

Admin message