Commit 4f2f76f7 authored May 25, 2018 by Jan Kara Committed by Theodore Ts'o May 25, 2018

ext4: fix fencepost error in check for inode count overflow during resize



ext4_resize_fs() has an off-by-one bug when checking whether growing of
a filesystem will not overflow inode count. As a result it allows a
filesystem with 8192 inodes per group to grow to 64TB which overflows
inode count to 0 and makes filesystem unusable. Fix it.

Cc: stable@vger.kernel.org
Fixes: 3f8a6411
Reported-by: Jaco Kroon <jaco@uls.co.za>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>

parent 8a2b307c

fs/ext4/resize.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1933,7 +1933,7 @@ retry:
		return 0;

		n_group = ext4_get_group_number(sb, n_blocks_count - 1);
		if (n_group > (0xFFFFFFFFUL / EXT4_INODES_PER_GROUP(sb))) {
		if (n_group >= (0xFFFFFFFFUL / EXT4_INODES_PER_GROUP(sb))) {
		ext4_warning(sb, "resize would cause inodes_count overflow");
		return -EINVAL;
		}

Admin message