Commit 4f258cf4 authored by Randy Dunlap's avatar Randy Dunlap Committed by Darren Hart (VMware)
Browse files

platform/x86: have ACPI_CMPC use depends instead of select for INPUT



Drivers should not 'select' a subsystem. Instead they should depend
on it. If the subsystem is disabled, the user probably did that for
a purpose and one driver shouldn't be changing that.

This also makes all platform/x86/ drivers consistent w.r.t depending on
INPUT instead of selecting it.

Signed-off-by: default avatarRandy Dunlap <rdunlap@infradead.org>
Cc: Andy Shevchenko <andy@infradead.org>
Cc: platform-driver-x86@vger.kernel.org
Signed-off-by: default avatarDarren Hart (VMware) <dvhart@infradead.org>
parent 28d71ae9
Loading
Loading
Loading
Loading
+1 −2
Original line number Diff line number Diff line
@@ -838,9 +838,8 @@ config TOSHIBA_WMI

config ACPI_CMPC
	tristate "CMPC Laptop Extras"
	depends on ACPI
	depends on ACPI && INPUT
	depends on RFKILL || RFKILL=n
	select INPUT
	select BACKLIGHT_CLASS_DEVICE
	help
	  Support for Intel Classmate PC ACPI devices, including some