Commit 4f1bdf0a authored Oct 10, 2017 by Maciej S. Szmigiero Committed by Mauro Carvalho Chehab Dec 11, 2017

media: cx25840: fix a possible divide by zero in set_fmt callback



If set_fmt callback is called with format->width or format->height set to
zero and HACTIVE_CNT or VACTIVE_CNT bits (respectively) in chip are zero
we will divide by zero later in this callback when we try to calculate
HSC or VSC values.

Fix this by explicitly rejecting these values.

Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

parent 7ff06130

drivers/media/i2c/cx25840/cx25840-core.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -1395,7 +1395,8 @@ static int cx25840_set_fmt(struct v4l2_subdev *sd,
		* height. Without that margin the cx23885 fails in this
		* check.
		*/
		if ((fmt->width * 16 < Hsrc) \|\| (Hsrc < fmt->width) \|\|
		if ((fmt->width == 0) \|\| (Vlines == 0) \|\|
		(fmt->width * 16 < Hsrc) \|\| (Hsrc < fmt->width) \|\|
		(Vlines * 8 < Vsrc) \|\| (Vsrc + 1 < Vlines)) {
		v4l_err(client, "%dx%d is not a valid size!\n",
		fmt->width, fmt->height);

Admin message