Commit 4f0611af authored May 15, 2009 by Stephen Hemminger Committed by David S. Miller May 17, 2009

bridge: fix initial packet flood if !STP



If bridge is configured with no STP and forwarding delay of 0 (which
is typical for virtualization) then when link starts it will flood all
packets for the first 20 seconds.

This bug was introduced by a combination of earlier changes:
  * forwarding database uses hold time of zero to indicate
    user wants to always flood packets
  * optimzation of the case of forwarding delay of 0 avoids the initial
    timer tick

The fix is to just skip all the topology change detection code if
kernel STP is not being used.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent a598f6ae

net/bridge/br_stp.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -297,6 +297,9 @@ void br_topology_change_detection(struct net_bridge *br)
		{
		int isroot = br_is_root_bridge(br);

		if (br->stp_enabled != BR_KERNEL_STP)
		return;

		pr_info("%s: topology change detected, %s\n", br->dev->name,
		isroot ? "propagating" : "sending tcn bpdu");

Admin message