Commit 4eebff27 authored by Konstantin Khlebnikov's avatar Konstantin Khlebnikov Committed by David S. Miller
Browse files

tcp_nv: fix division by zero in tcpnv_acked() 



Average RTT could become zero. This happened in real life at least twice.
This patch treats zero as 1us.

Signed-off-by: default avatarKonstantin Khlebnikov <khlebnikov@yandex-team.ru>
Acked-by: default avatarLawrence Brakmo <Brakmo@fb.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 3a99df9a

net/ipv4/tcp_nv.c

+1 −1
Original line number Diff line number Diff line
@@ -252,7 +252,7 @@ static void tcpnv_acked(struct sock *sk, const struct ack_sample *sample) 


	/* rate in 100's bits per second */

	rate64 = ((u64)sample->in_flight) * 8000000;

	rate = (u32)div64_u64(rate64, (u64)(avg_rtt * 100));

	rate = (u32)div64_u64(rate64, (u64)(avg_rtt ?: 1) * 100);



	/* Remember the maximum rate seen during this RTT

	 * Note: It may be more than one RTT. This function should be

CRA Git | Maintained and supported by SUSTech CRA and CCSE