Commit 4ee48cc5 authored Jul 23, 2020 by Biju Das Committed by Sam Ravnborg Jul 26, 2020

drm: of: Fix double-free bug



Fix double-free bug in the error path.

Fixes: 65290075 ("drm: of: Add drm_of_lvds_get_dual_link_pixel_order")
Reported-by: Pavel Machek <pavel@denx.de>
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: stable@vger.kernel.org
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/1595502654-40595-1-git-send-email-biju.das.jz@bp.renesas.com

parent f3f90c6d

drivers/gpu/drm/drm_of.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -322,11 +322,9 @@ static int drm_of_lvds_get_remote_pixels_type(
		* configurations by passing the endpoints explicitly to
		* drm_of_lvds_get_dual_link_pixel_order().
		*/
		if (!current_pt \|\| pixels_type != current_pt) {
		of_node_put(remote_port);
		if (!current_pt \|\| pixels_type != current_pt)
		return -EINVAL;
		}
		}

		return pixels_type;
		}

Admin message