Commit 4ed55016 authored Feb 20, 2017 by Andy Shevchenko Committed by Linus Walleij Mar 16, 2017

gpio: acpi: Don't return 0 on acpi_gpio_count()



It's unusual to have error checking like (ret <= 0) in cases when
counting GPIO resources. In case when it's mandatory we propagate the
error (-ENOENT), otherwise we don't use the result.

This makes consistent behaviour across all possible variants called in
gpiod_count().

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 529f75d8

drivers/gpio/gpiolib-acpi.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1098,7 +1098,7 @@ int acpi_gpio_count(struct device dev, const char con_id)
		break;
		}
		}
		if (count >= 0)
		if (count > 0)
		break;
		}

		@@ -1114,7 +1114,7 @@ int acpi_gpio_count(struct device dev, const char con_id)
		if (crs_count > 0)
		count = crs_count;
		}
		return count;
		return count ? count : -ENOENT;
		}

		struct acpi_crs_lookup {

Admin message