Commit 4eb5fec3 authored Apr 30, 2019 by Lianbo Jiang Committed by Borislav Petkov Jun 20, 2019

fs/proc/vmcore: Enable dumping of encrypted memory when SEV was active



In the kdump kernel, the memory of the first kernel gets to be dumped
into a vmcore file.

Similarly to SME kdump, if SEV was enabled in the first kernel, the old
memory has to be remapped encrypted in order to access it properly.

Commit

  992b649a ("kdump, proc/vmcore: Enable kdumping encrypted memory with SME enabled")

took care of the SME case but it uses sme_active() which checks for SME
only. Use mem_encrypt_active() instead, which returns true when either
SME or SEV is active.

Unlike SME, the second kernel images (kernel and initrd) are loaded into
encrypted memory when SEV is active, hence the kernel elf header must be
remapped as encrypted in order to access it properly.

 [ bp: Massage commit message. ]

Co-developed-by: Brijesh Singh <brijesh.singh@amd.com>
Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>
Signed-off-by: Lianbo Jiang <lijiang@redhat.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: bhe@redhat.com
Cc: dyoung@redhat.com
Cc: Ganesh Goudar <ganeshgr@chelsio.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: kexec@lists.infradead.org
Cc: linux-fsdevel@vger.kernel.org
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Mike Rapoport <rppt@linux.vnet.ibm.com>
Cc: mingo@redhat.com
Cc: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Cc: Souptick Joarder <jrdr.linux@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Cc: x86-ml <x86@kernel.org>
Link: https://lkml.kernel.org/r/20190430074421.7852-4-lijiang@redhat.com

parent 85784d16

fs/proc/vmcore.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -166,7 +166,7 @@ void __weak elfcorehdr_free(unsigned long long addr)
		*/
		ssize_t __weak elfcorehdr_read(char buf, size_t count, u64 ppos)
		{
		return read_from_oldmem(buf, count, ppos, 0, false);
		return read_from_oldmem(buf, count, ppos, 0, sev_active());
		}

		/*
		@@ -174,7 +174,7 @@ ssize_t __weak elfcorehdr_read(char buf, size_t count, u64 ppos)
		*/
		ssize_t __weak elfcorehdr_read_notes(char buf, size_t count, u64 ppos)
		{
		return read_from_oldmem(buf, count, ppos, 0, sme_active());
		return read_from_oldmem(buf, count, ppos, 0, mem_encrypt_active());
		}

		/*
		@@ -374,7 +374,7 @@ static ssize_t __read_vmcore(char buffer, size_t buflen, loff_t fpos,
		buflen);
		start = m->paddr + *fpos - m->offset;
		tmp = read_from_oldmem(buffer, tsz, &start,
		userbuf, sme_active());
		userbuf, mem_encrypt_active());
		if (tmp < 0)
		return tmp;
		buflen -= tsz;

Admin message