virtio-pci: read the right virtio_pci_notify_cap field (4e94ebdd) · Commits · 戴 / test

Looks like a copy-paste bug. The value is used as an optimization and a wrong value probably isn't causing any serious damage. Found when porting this code to Windows. Signed-off-by:

Ladi Prosek <lprosek@redhat.com> Signed-off-by:

Michael S. Tsirkin <mst@redhat.com>

drivers/virtio/virtio_pci_modern.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -679,7 +679,7 @@ int virtio_pci_modern_probe(struct virtio_pci_device *vp_dev)

	pci_read_config_dword(pci_dev,		pci_read_config_dword(pci_dev,
	notify + offsetof(struct virtio_pci_notify_cap,		notify + offsetof(struct virtio_pci_notify_cap,
	cap.length),		cap.offset),
	&notify_offset);		&notify_offset);

	/* We don't know how many VQs we'll map, ahead of the time.		/* We don't know how many VQs we'll map, ahead of the time.

Admin message