Commit 4e8439aa authored by Stefan Agner's avatar Stefan Agner Committed by David S. Miller
Browse files

net: hamradio: use eth_broadcast_addr 



The array bpq_eth_addr is only used to get the size of an
address, whereas the bcast_addr is used to set the broadcast
address. This leads to a warning when using clang:
drivers/net/hamradio/bpqether.c:94:13: warning: variable 'bpq_eth_addr' is not
      needed and will not be emitted [-Wunneeded-internal-declaration]
static char bpq_eth_addr[6];
            ^

Remove both variables and use the common eth_broadcast_addr
to set the broadcast address.

Signed-off-by: default avatarStefan Agner <stefan@agner.ch>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 3256d29f

drivers/net/hamradio/bpqether.c

+2 −6
Original line number Original line Diff line number Diff line
@@ -89,10 +89,6 @@ 
static const char banner[] __initconst = KERN_INFO \

static const char banner[] __initconst = KERN_INFO \

	"AX.25: bpqether driver version 004\n";

	"AX.25: bpqether driver version 004\n";





static char bcast_addr[6]={0xFF,0xFF,0xFF,0xFF,0xFF,0xFF};



static char bpq_eth_addr[6];



static int bpq_rcv(struct sk_buff *, struct net_device *, struct packet_type *, struct net_device *);

static int bpq_rcv(struct sk_buff *, struct net_device *, struct packet_type *, struct net_device *);

static int bpq_device_event(struct notifier_block *, unsigned long, void *);

static int bpq_device_event(struct notifier_block *, unsigned long, void *);
@@ -501,8 +497,8 @@ static int bpq_new_device(struct net_device *edev) 
	bpq->ethdev = edev;

	bpq->ethdev = edev;

	bpq->axdev = ndev;

	bpq->axdev = ndev;





	memcpy(bpq->dest_addr, bcast_addr, sizeof(bpq_eth_addr));

	eth_broadcast_addr(bpq->dest_addr);

	memcpy(bpq->acpt_addr, bcast_addr, sizeof(bpq_eth_addr));

	eth_broadcast_addr(bpq->acpt_addr);





	err = register_netdevice(ndev);

	err = register_netdevice(ndev);

	if (err)

	if (err)

CRA Git | Maintained and supported by SUSTech CRA and CCSE