Unverified Commit 4e7f8cac authored Jul 07, 2020 by Daniel Baluta Committed by Mark Brown Jul 08, 2020

ASoC: SOF: imx: add min/max channels for SAI/ESAI on i.MX8/i.MX8M



This is identical with change for Intel platforms done with
commit 8c05246c ("ASoC: SOF: Intel: add min/max channels for SSP on Baytrail/Broadwell")
and fixes a regression on i.MX8/i.MX8M:

[   25.705750]  esai-Codec: ASoC: no backend playback stream
[   27.923378]  esai-Codec: ASoC: no users playback at close - state

This is root-caused to the introduction of the DAI capability checks
with snd_soc_dai_stream_valid(). Its use in soc-pcm.c makes it a
requirement for all DAIs to report at least a non-zero min_channels
field.

Fixes: 9b5db059 ("ASoC: soc-pcm: dpcm: Only allow playback/capture if supported")
Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Link: https://lore.kernel.org/r/20200707210439.115300-4-pierre-louis.bossart@linux.intel.com


Signed-off-by: Mark Brown <broonie@kernel.org>

parent fffebe8a

sound/soc/sof/imx/imx8.c

+8 −0

Original line number	Diff line number	Diff line
		@@ -375,6 +375,14 @@ static int imx8_ipc_pcm_params(struct snd_sof_dev *sdev,
		static struct snd_soc_dai_driver imx8_dai[] = {
		{
		.name = "esai-port",
		.playback = {
		.channels_min = 1,
		.channels_max = 8,
		},
		.capture = {
		.channels_min = 1,
		.channels_max = 8,
		},
		},
		};

sound/soc/sof/imx/imx8m.c

+8 −0

Original line number	Diff line number	Diff line
		@@ -240,6 +240,14 @@ static int imx8m_ipc_pcm_params(struct snd_sof_dev *sdev,
		static struct snd_soc_dai_driver imx8m_dai[] = {
		{
		.name = "sai-port",
		.playback = {
		.channels_min = 1,
		.channels_max = 32,
		},
		.capture = {
		.channels_min = 1,
		.channels_max = 32,
		},
		},
		};

Admin message