Commit 4e6b86b4 authored Nov 26, 2020 by Lad Prabhakar Committed by Krzysztof Kozlowski Nov 28, 2020

memory: renesas-rpc-if: Fix a node reference leak in rpcif_probe()



Release the node reference by calling of_node_put(flash) in the probe.

Fixes: ca7d8b98 ("memory: add Renesas RPC-IF driver")
Reported-by: Pavel Machek <pavel@denx.de>
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Sergei Shtylyov <sergei.shtylyov@gmail.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Pavel Machek (CIP) <pavel@denx.de>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20201126191146.8753-4-prabhakar.mahadev-lad.rj@bp.renesas.com


Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

parent 61a6d854

drivers/memory/renesas-rpc-if.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -561,9 +561,11 @@ static int rpcif_probe(struct platform_device *pdev)
		} else if (of_device_is_compatible(flash, "cfi-flash")) {
		name = "rpc-if-hyperflash";
		} else {
		of_node_put(flash);
		dev_warn(&pdev->dev, "unknown flash type\n");
		return -ENODEV;
		}
		of_node_put(flash);

		vdev = platform_device_alloc(name, pdev->id);
		if (!vdev)

Admin message