Commit 4e37d691 authored Feb 23, 2017 by Matthias Schiffer Committed by David S. Miller Feb 24, 2017

vxlan: correctly validate VXLAN ID against VXLAN_N_VID



The incorrect check caused an off-by-one error: the maximum VID 0xffffff
was unusable.

Fixes: d342894c ("vxlan: virtual extensible lan")
Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
Acked-by: Jiri Benc <jbenc@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 681a55d7

drivers/net/vxlan.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2675,7 +2675,7 @@ static int vxlan_validate(struct nlattr tb[], struct nlattr data[])

		if (data[IFLA_VXLAN_ID]) {
		__u32 id = nla_get_u32(data[IFLA_VXLAN_ID]);
		if (id >= VXLAN_VID_MASK)
		if (id >= VXLAN_N_VID)
		return -ERANGE;
		}

Admin message