Commit 4e361d3c authored May 24, 2017 by Takashi Sakamoto Committed by Takashi Iwai May 24, 2017

ALSA: control: remove entry limitation for list operation



In current implementation of ALSA control core, list operation has
a limitation to handle 16384 entries at once. This seems due to
allocation in kernel space to copy data from user space.

With a commit 53e7bf45 ("ALSA: control: Simplify snd_ctl_elem_list()
implementation"), for the operation, ALSA control core copies data
into user space directly. No need to care of kernel spaces anymore.

This commit purges the limitation.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent ffb73b08

sound/core/control.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -757,9 +757,7 @@ static int snd_ctl_elem_list(struct snd_card *card,
		return -EFAULT;
		offset = list.offset;
		space = list.space;
		/* try limit maximum space */
		if (space > 16384)
		return -ENOMEM;

		down_read(&card->controls_rwsem);
		list.count = card->controls_count;
		list.used = 0;

Admin message