Commit 4e2f0775 authored May 29, 2012 by Gavin Shan Committed by Linus Torvalds May 29, 2012

mm/memblock: cleanup on duplicate VA/PA conversion

The overall memblock has been organized into the memory regions and
reserved regions. Initially, the memory regions and reserved regions are
stored in the predetermined arrays of "struct memblock _region". It's
possible for the arrays to be enlarged when we have newly added regions
for them, but no enough space there. Under the situation, We will created
double-sized array to meet the requirement. However, the original
implementation converted the VA (Virtual Address) of the newly allocated
array of regions to PA (Physical Address), then translate back when we
allocates the new array from slab. That's actually unnecessary.

The patch removes the duplicate VA/PA conversion.

Signed-off-by: Gavin Shan <shangw@linux.vnet.ibm.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 5bf5f03c

mm/memblock.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -212,14 +212,15 @@ static int __init_memblock memblock_double_array(struct memblock_type *type)
		if (use_slab) {
		new_array = kmalloc(new_size, GFP_KERNEL);
		addr = new_array ? __pa(new_array) : 0;
		} else
		} else {
		addr = memblock_find_in_range(0, MEMBLOCK_ALLOC_ACCESSIBLE, new_size, sizeof(phys_addr_t));
		new_array = addr ? __va(addr) : 0;
		}
		if (!addr) {
		pr_err("memblock: Failed to double %s array from %ld to %ld entries !\n",
		memblock_type_name(type), type->max, type->max * 2);
		return -1;
		}
		new_array = __va(addr);

		memblock_dbg("memblock: %s array is doubled to %ld at [%#010llx-%#010llx]",
		memblock_type_name(type), type->max * 2, (u64)addr, (u64)addr + new_size - 1);

Admin message