Commit 4e26fabf authored Oct 10, 2019 by Srinivas Pandruvada Committed by Andy Shevchenko Oct 15, 2019

tools/power/x86/intel-speed-select: Refuse to disable core-power when getting used

The turbo-freq feature is dependent on the core-power feature. If the
core-power feature is disabled while the turbo-freq feature is enabled,
this will break the turbo-freq feature. This is a firmware limitation,
where they can't return error under this scenario.

So when trying to disable core-power, make sure that the turbo-freq
feature is not enabled. If it enabled, return error if user is trying to
disable the core-power feature.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

parent a6a82f9b

tools/power/x86/intel-speed-select/isst-core.c

+21 −0

Original line number	Diff line number	Diff line
		@@ -649,6 +649,27 @@ int isst_pm_qos_config(int cpu, int enable_clos, int priority_type)
		unsigned int req, resp;
		int ret;

		if (!enable_clos) {
		struct isst_pkg_ctdp pkg_dev;
		struct isst_pkg_ctdp_level_info ctdp_level;

		ret = isst_get_ctdp_levels(cpu, &pkg_dev);
		if (ret) {
		debug_printf("isst_get_ctdp_levels\n");
		return ret;
		}

		ret = isst_get_ctdp_control(cpu, pkg_dev.current_level,
		&ctdp_level);
		if (ret)
		return ret;

		if (ctdp_level.fact_enabled) {
		debug_printf("Turbo-freq feature must be disabled first\n");
		return -EINVAL;
		}
		}

		ret = isst_send_mbox_command(cpu, CONFIG_CLOS, CLOS_PM_QOS_CONFIG, 0, 0,
		&resp);
		if (ret)

Admin message