Commit 4e24e37d authored Oct 31, 2019 by Qian Cai Committed by Dan Williams Nov 17, 2019

libnvdimm/btt: fix variable 'rc' set but not used



drivers/nvdimm/btt.c: In function 'btt_read_pg':
drivers/nvdimm/btt.c:1264:8: warning: variable 'rc' set but not used
[-Wunused-but-set-variable]
    int rc;
        ^~

Add a ratelimited message in case a storm of errors is encountered.

Fixes: d9b83c75 ("libnvdimm, btt: rework error clearing")
Signed-off-by: Qian Cai <cai@lca.pw>
Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
Link: https://lore.kernel.org/r/1572530719-32161-1-git-send-email-cai@lca.pw


Signed-off-by: Dan Williams <dan.j.williams@intel.com>

parent d7c0d927

drivers/nvdimm/btt.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -1261,11 +1261,11 @@ static int btt_read_pg(struct btt btt, struct bio_integrity_payload bip,

		ret = btt_data_read(arena, page, off, postmap, cur_len);
		if (ret) {
		int rc;

		/* Media error - set the e_flag */
		rc = btt_map_write(arena, premap, postmap, 0, 1,
		NVDIMM_IO_ATOMIC);
		if (btt_map_write(arena, premap, postmap, 0, 1, NVDIMM_IO_ATOMIC))
		dev_warn_ratelimited(to_dev(arena),
		"Error persistently tracking bad blocks at %#x\n",
		premap);
		goto out_rtt;
		}

Admin message