Commit 4e2284d2 authored May 19, 2013 by Jean Delvare Committed by Guenter Roeck May 19, 2013

hwmon: (tmp401) Drop redundant safety on cache lifetime

time_after (as opposed to time_after_equal) already ensures that the
cache lifetime is at least as much as requested. There is no point in
manually adding another jiffy to that value, and this can confuse the
reader into wrong interpretation.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: Imre Deak <imre.deak@intel.com>
Cc: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

parent ecacb0b1

drivers/hwmon/tmp401.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -240,7 +240,7 @@ static struct tmp401_data tmp401_update_device(struct device dev)
		mutex_lock(&data->update_lock);

		next_update = data->last_updated +
		msecs_to_jiffies(data->update_interval) + 1;
		msecs_to_jiffies(data->update_interval);
		if (time_after(jiffies, next_update) \|\| !data->valid) {
		if (data->kind != tmp432) {
		/*

Admin message