Commit 4e1a6911 authored Jul 02, 2020 by Wei Yongjun Committed by David S. Miller Jul 02, 2020

mlx4: Mark PM functions as __maybe_unused



In certain configurations without power management support, the
following warnings happen:

drivers/net/ethernet/mellanox/mlx4/main.c:4388:12:
 warning: 'mlx4_resume' defined but not used [-Wunused-function]
 4388 | static int mlx4_resume(struct device *dev_d)
      |            ^~~~~~~~~~~
drivers/net/ethernet/mellanox/mlx4/main.c:4373:12: warning:
 'mlx4_suspend' defined but not used [-Wunused-function]
 4373 | static int mlx4_suspend(struct device *dev_d)
      |            ^~~~~~~~~~~~

Mark these functions as __maybe_unused to make it clear to the
compiler that this is going to happen based on the configuration,
which is the standard for these types of functions.

Fixes: 0e3e206a ("mlx4: use generic power management")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent ffa76e38

drivers/net/ethernet/mellanox/mlx4/main.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -4370,7 +4370,7 @@ static const struct pci_error_handlers mlx4_err_handler = {
		.resume = mlx4_pci_resume,
		};

		static int mlx4_suspend(struct device *dev_d)
		static int __maybe_unused mlx4_suspend(struct device *dev_d)
		{
		struct pci_dev *pdev = to_pci_dev(dev_d);
		struct mlx4_dev_persistent *persist = pci_get_drvdata(pdev);
		@@ -4385,7 +4385,7 @@ static int mlx4_suspend(struct device *dev_d)
		return 0;
		}

		static int mlx4_resume(struct device *dev_d)
		static int __maybe_unused mlx4_resume(struct device *dev_d)
		{
		struct pci_dev *pdev = to_pci_dev(dev_d);
		struct mlx4_dev_persistent *persist = pci_get_drvdata(pdev);

Admin message