Commit 4e19d51c authored Oct 03, 2020 by Tom Rix Committed by Daniel Vetter Oct 05, 2020

drm/gma500: fix double free of gma_connector



clang static analysis reports this problem:

cdv_intel_dp.c:2101:2: warning: Attempt to free released memory
        kfree(gma_connector);
        ^~~~~~~~~~~~~~~~~~~~

In cdv_intel_dp_init() when the call to cdv_intel_edp_panel_vdd_off()
fails, the handler calls cdv_intel_dp_destroy(connector) which does
the first free of gma_connector. So adjust the goto label and skip
the second free.

Fixes: d112a816 ("gma500/cdv: Add eDP support")
Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20201003193928.18869-1-trix@redhat.com

parent 170fb58e

drivers/gpu/drm/gma500/cdv_intel_dp.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2082,7 +2082,7 @@ cdv_intel_dp_init(struct drm_device dev, struct psb_intel_mode_device mode_dev
		DRM_INFO("failed to retrieve link info, disabling eDP\n");
		drm_encoder_cleanup(encoder);
		cdv_intel_dp_destroy(connector);
		goto err_priv;
		goto err_connector;
		} else {
		DRM_DEBUG_KMS("DPCD: Rev=%x LN_Rate=%x LN_CNT=%x LN_DOWNSP=%x\n",
		intel_dp->dpcd[0], intel_dp->dpcd[1],

Admin message