iio: position: iqs624: remove usage of iio_priv_to_dev() (4de87f45) · Commits · 戴 / test

We may want to get rid of the iio_priv_to_dev() helper. That's a bit uncertain at this point. The reason is that we will hide some of the members of the iio_dev structure (to prevent drivers from accessing them directly), and that will also mean hiding the implementation of the iio_priv_to_dev() helper inside the IIO core. Hiding the implementation of iio_priv_to_dev() implies that some fast-paths may not be fast anymore, so a general idea is to try to get rid of the iio_priv_to_dev() altogether. For this driver, removing iio_priv_to_dev() also means keeping a reference on the state struct. Signed-off-by:

Alexandru Ardelean <alexandru.ardelean@analog.com> Acked-by:

Jeff LaBundy <jeff@labundy.com> Signed-off-by:

Jonathan Cameron <Jonathan.Cameron@huawei.com>

drivers/iio/position/iqs624-pos.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -23,6 +23,7 @@

		struct iqs624_pos_private {
		struct iqs62x_core *iqs62x;
		struct iio_dev *indio_dev;
		struct notifier_block notifier;
		struct mutex lock;
		bool angle_en;
		@@ -59,7 +60,7 @@ static int iqs624_pos_notifier(struct notifier_block *notifier,

		iqs624_pos = container_of(notifier, struct iqs624_pos_private,
		notifier);
		indio_dev = iio_priv_to_dev(iqs624_pos);
		indio_dev = iqs624_pos->indio_dev;
		timestamp = iio_get_time_ns(indio_dev);

		iqs62x = iqs624_pos->iqs62x;
		@@ -98,7 +99,7 @@ static int iqs624_pos_notifier(struct notifier_block *notifier,
		static void iqs624_pos_notifier_unregister(void *context)
		{
		struct iqs624_pos_private *iqs624_pos = context;
		struct iio_dev *indio_dev = iio_priv_to_dev(iqs624_pos);
		struct iio_dev *indio_dev = iqs624_pos->indio_dev;
		int ret;

		ret = blocking_notifier_chain_unregister(&iqs624_pos->iqs62x->nh,
		@@ -243,6 +244,7 @@ static int iqs624_pos_probe(struct platform_device *pdev)

		iqs624_pos = iio_priv(indio_dev);
		iqs624_pos->iqs62x = iqs62x;
		iqs624_pos->indio_dev = indio_dev;

		indio_dev->modes = INDIO_DIRECT_MODE;
		indio_dev->dev.parent = &pdev->dev;

Admin message