Commit 4de0a835 authored Nov 19, 2019 by zhengbin Committed by Paul Mackerras Jan 17, 2020

KVM: PPC: Remove set but not used variable 'ra', 'rs', 'rt'

Fixes gcc '-Wunused-but-set-variable' warning:

arch/powerpc/kvm/emulate_loadstore.c: In function kvmppc_emulate_loadstore:
arch/powerpc/kvm/emulate_loadstore.c:87:6: warning: variable ra set but not used [-Wunused-but-set-variable]
arch/powerpc/kvm/emulate_loadstore.c: In function kvmppc_emulate_loadstore:
arch/powerpc/kvm/emulate_loadstore.c:87:10: warning: variable rs set but not used [-Wunused-but-set-variable]
arch/powerpc/kvm/emulate_loadstore.c: In function kvmppc_emulate_loadstore:
arch/powerpc/kvm/emulate_loadstore.c:87:14: warning: variable rt set but not used [-Wunused-but-set-variable]

They are not used since commit 2b33cb58 ("KVM: PPC: Reimplement
LOAD_FP/STORE_FP instruction mmio emulation with analyse_instr() input")

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
Signed-off-by: Paul Mackerras <paulus@ozlabs.org>

parent c79f46a2

arch/powerpc/kvm/emulate_loadstore.c

+0 −5

Original line number	Diff line number	Diff line
		@@ -73,7 +73,6 @@ int kvmppc_emulate_loadstore(struct kvm_vcpu *vcpu)
		{
		struct kvm_run *run = vcpu->run;
		u32 inst;
		int ra, rs, rt;
		enum emulation_result emulated = EMULATE_FAIL;
		int advance = 1;
		struct instruction_op op;
		@@ -85,10 +84,6 @@ int kvmppc_emulate_loadstore(struct kvm_vcpu *vcpu)
		if (emulated != EMULATE_DONE)
		return emulated;

		ra = get_ra(inst);
		rs = get_rs(inst);
		rt = get_rt(inst);

		vcpu->arch.mmio_vsx_copy_nums = 0;
		vcpu->arch.mmio_vsx_offset = 0;
		vcpu->arch.mmio_copy_type = KVMPPC_VSX_COPY_NONE;

Admin message