Commit 4dde507f authored Feb 11, 2014 by Lv Zheng Committed by Rafael J. Wysocki Feb 13, 2014

ACPICA: Add boot option to disable auto return object repair

Sometimes, there might be bugs caused by unexpected AML which is compliant
to the Windows but not compliant to the Linux implementation.

There is a predefined validation mechanism implemented in ACPICA to repair
the unexpected AML evaluation results that are caused by the unexpected
AMLs. For example, BIOS may return misorder _CST result and the repair
mechanism can make an ascending order on the returned _CST package object
based on the C-state type.
This mechanism is quite useful to implement an AML interpreter with better
compliance with the real world where Windows is the de-facto standard and
BIOS codes are only tested on one platform thus not compliant to the
ACPI specification.

But if a compliance issue hasn't been figured out yet, it will be
difficult for developers to identify if the unexpected evaluation result
is caused by this mechanism or by the AML interpreter.
For example, _PR0 is expected to be a control method, but BIOS may use
Package: "Name(_PR0, Package(1) {P1PR})".
This boot option can disable the predefined validation mechanism so that
developers can make sure the root cause comes from the parser/executer.

This patch adds a new kernel parameter to disable this feature.

A build test has been made on a Dell Inspiron mini 1100 (i386 z530)
machine when this patch is applied and the corresponding boot test is
performed w/ or w/o the new kernel parameter specified.

References: https://bugzilla.kernel.org/show_bug.cgi?id=67901

Tested-by: Fabian Wehning <fabian.wehning@googlemail.com>
Signed-off-by: Lv Zheng <lv.zheng@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent e252652f

Documentation/kernel-parameters.txt

+8 −0

Original line number	Diff line number	Diff line
		@@ -231,6 +231,14 @@ bytes respectively. Such letter suffixes can also be entirely omitted.

		acpi_no_auto_ssdt [HW,ACPI] Disable automatic loading of SSDT

		acpica_no_return_repair [HW, ACPI]
		Disable AML predefined validation mechanism
		This mechanism can repair the evaluation result to make
		the return objects more ACPI specification compliant.
		This option is useful for developers to identify the
		root cause of an AML interpreter issue when the issue
		has something to do with the repair mechanism.

		acpi_os_name= [HW,ACPI] Tell ACPI BIOS the name of the OS
		Format: To spoof as Windows 98: ="Microsoft Windows"

drivers/acpi/osl.c

+11 −0

Original line number	Diff line number	Diff line
		@@ -1780,6 +1780,17 @@ static int __init acpi_no_auto_ssdt_setup(char *s)

		__setup("acpi_no_auto_ssdt", acpi_no_auto_ssdt_setup);

		static int __init acpi_disable_return_repair(char *s)
		{
		printk(KERN_NOTICE PREFIX
		"ACPI: Predefined validation mechanism disabled\n");
		acpi_gbl_disable_auto_repair = TRUE;

		return 1;
		}

		__setup("acpica_no_return_repair", acpi_disable_return_repair);

		acpi_status __init acpi_os_initialize(void)
		{
		acpi_os_map_generic_address(&acpi_gbl_FADT.xpm1a_event_block);

Admin message