Commit 4dc05efb authored Sep 23, 2008 by Trond Myklebust

NFS: Convert __nfs_revalidate_inode() to use nfs_refresh_inode()



In the case where there are parallel RPC calls to the same inode, we may
receive stale metadata due to the lack of ordering, hence the sanity
checking of metadata in nfs_refresh_inode().
Currently, __nfs_revalidate_inode() is calling nfs_update_inode() directly,
without any further sanity checks, and hence may end up setting the inode
up with stale metadata.

Fix is to use nfs_refresh_inode() instead of nfs_update_inode().

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

parent d65f557f

fs/nfs/inode.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -724,16 +724,13 @@ __nfs_revalidate_inode(struct nfs_server server, struct inode inode)
		goto out;
		}

		spin_lock(&inode->i_lock);
		status = nfs_update_inode(inode, &fattr);
		status = nfs_refresh_inode(inode, &fattr);
		if (status) {
		spin_unlock(&inode->i_lock);
		dfprintk(PAGECACHE, "nfs_revalidate_inode: (%s/%Ld) refresh failed, error=%d\n",
		inode->i_sb->s_id,
		(long long)NFS_FILEID(inode), status);
		goto out;
		}
		spin_unlock(&inode->i_lock);

		if (nfsi->cache_validity & NFS_INO_INVALID_ACL)
		nfs_zap_acl_cache(inode);

Admin message