Commit 4dbccb87 authored Apr 07, 2020 by Dan Carpenter Committed by Andy Shevchenko Apr 17, 2020

platform/x86: surface3_power: Fix a NULL vs IS_ERR() check in probe



The i2c_acpi_new_device() function never returns NULL, it returns error
pointers.

Fixes: b1f81b49 ("platform/x86: surface3_power: MSHW0011 rev-eng implementation")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

parent 8f3d9f35

drivers/platform/x86/surface3_power.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -522,8 +522,8 @@ static int mshw0011_probe(struct i2c_client *client)
		strlcpy(board_info.type, "MSHW0011-bat0", I2C_NAME_SIZE);

		bat0 = i2c_acpi_new_device(dev, 1, &board_info);
		if (!bat0)
		return -ENOMEM;
		if (IS_ERR(bat0))
		return PTR_ERR(bat0);

		data->bat0 = bat0;
		i2c_set_clientdata(bat0, data);

Admin message