Commit 4da24fa6 authored by Edward Cree's avatar Edward Cree Committed by David S. Miller
Browse files

sfc: cleanups around efx_alloc_channel 



The old_channel argument is never used, so remove it.
The function is only called from elsewhere in efx_channels.c, so make
 it static and remove the declaration from the header file.

Signed-off-by: default avatarEdward Cree <ecree@solarflare.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 3d6aef65

drivers/net/ethernet/sfc/efx_channels.c

+2 −3
Original line number Diff line number Diff line
@@ -505,8 +505,7 @@ static void efx_filter_rfs_expire(struct work_struct *data) 
#endif



/* Allocate and initialise a channel structure. */

struct efx_channel *

efx_alloc_channel(struct efx_nic *efx, int i, struct efx_channel *old_channel)

static struct efx_channel *efx_alloc_channel(struct efx_nic *efx, int i)

{

	struct efx_rx_queue *rx_queue;

	struct efx_tx_queue *tx_queue;
@@ -545,7 +544,7 @@ int efx_init_channels(struct efx_nic *efx) 
	unsigned int i;



	for (i = 0; i < EFX_MAX_CHANNELS; i++) {

		efx->channel[i] = efx_alloc_channel(efx, i, NULL);

		efx->channel[i] = efx_alloc_channel(efx, i);

		if (!efx->channel[i])

			return -ENOMEM;

		efx->msi_context[i].efx = efx;

drivers/net/ethernet/sfc/efx_channels.h

+0 −2
Original line number Diff line number Diff line
@@ -31,8 +31,6 @@ void efx_stop_eventq(struct efx_channel *channel); 
void efx_fini_eventq(struct efx_channel *channel);

void efx_remove_eventq(struct efx_channel *channel);



struct efx_channel *

efx_alloc_channel(struct efx_nic *efx, int i, struct efx_channel *old_channel);

int efx_realloc_channels(struct efx_nic *efx, u32 rxq_entries, u32 txq_entries);

void efx_get_channel_name(struct efx_channel *channel, char *buf, size_t len);

void efx_set_channel_names(struct efx_nic *efx);

CRA Git | Maintained and supported by SUSTech CRA and CCSE