Commit 4da1f792 authored Aug 06, 2018 by Michael Ellerman

powerpc/64: Disable irq restore warning for now



We recently added a warning in arch_local_irq_restore() to check that
the soft masking state matches reality.

Unfortunately it trips in a few places, which are not entirely trivial
to fix. The key problem is if we're doing function_graph tracing of
restore_math(), the warning pops and then seems to recurse. It's not
entirely clear because the system continuously oopses on all CPUs,
with the output interleaved and unreadable.

It's also been observed on a G5 coming out of idle.

Until we can fix those cases disable the warning for now.

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

parent 9eab9901

arch/powerpc/kernel/irq.c

+10 −3

Original line number	Diff line number	Diff line
		@@ -261,9 +261,16 @@ notrace void arch_local_irq_restore(unsigned long mask)
		*/
		irq_happened = get_irq_happened();
		if (!irq_happened) {
		#ifdef CONFIG_PPC_IRQ_SOFT_MASK_DEBUG
		WARN_ON(!(mfmsr() & MSR_EE));
		#endif
		/*
		* FIXME. Here we'd like to be able to do:
		*
		* #ifdef CONFIG_PPC_IRQ_SOFT_MASK_DEBUG
		* WARN_ON(!(mfmsr() & MSR_EE));
		* #endif
		*
		* But currently it hits in a few paths, we should fix those and
		* enable the warning.
		*/
		return;
		}

Admin message