Commit 4d9c5b89 authored by Christoffer Dall's avatar Christoffer Dall Committed by Russell King
Browse files

ARM: 7950/1: mm: Fix stage-2 device memory attributes 



The stage-2 memory attributes are distinct from the Hyp memory
attributes and the Stage-1 memory attributes.  We were using the stage-1
memory attributes for stage-2 mappings causing device mappings to be
mapped as normal memory.  Add the S2 equivalent defines for memory
attributes and fix the comments explaining the defines while at it.

Add a prot_pte_s2 field to the mem_type struct and fill out the field
for device mappings accordingly.

Cc: <stable@vger.kernel.org>	[3.9+]
Acked-by: default avatarMarc Zyngier <marc.zyngier@arm.com>
Acked-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
Signed-off-by: default avatarChristoffer Dall <christoffer.dall@linaro.org>
Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
parent 87f9260b

arch/arm/include/asm/pgtable-3level.h

+9 −6
Original line number Diff line number Diff line
@@ -120,9 +120,12 @@ 
/*

 * 2nd stage PTE definitions for LPAE.

 */

#define L_PTE_S2_MT_UNCACHED	 (_AT(pteval_t, 0x5) << 2) /* MemAttr[3:0] */

#define L_PTE_S2_MT_WRITETHROUGH (_AT(pteval_t, 0xa) << 2) /* MemAttr[3:0] */

#define L_PTE_S2_MT_WRITEBACK	 (_AT(pteval_t, 0xf) << 2) /* MemAttr[3:0] */

#define L_PTE_S2_MT_UNCACHED		(_AT(pteval_t, 0x0) << 2) /* strongly ordered */

#define L_PTE_S2_MT_WRITETHROUGH	(_AT(pteval_t, 0xa) << 2) /* normal inner write-through */

#define L_PTE_S2_MT_WRITEBACK		(_AT(pteval_t, 0xf) << 2) /* normal inner write-back */

#define L_PTE_S2_MT_DEV_SHARED		(_AT(pteval_t, 0x1) << 2) /* device */

#define L_PTE_S2_MT_MASK		(_AT(pteval_t, 0xf) << 2)



#define L_PTE_S2_RDONLY			(_AT(pteval_t, 1) << 6)   /* HAP[1]   */

#define L_PTE_S2_RDWR			(_AT(pteval_t, 3) << 6)   /* HAP[2:1] */

arch/arm/mm/mm.h

+1 −0
Original line number Diff line number Diff line
@@ -38,6 +38,7 @@ static inline pmd_t *pmd_off_k(unsigned long virt) 


struct mem_type {

	pteval_t prot_pte;

	pteval_t prot_pte_s2;

	pmdval_t prot_l1;

	pmdval_t prot_sect;

	unsigned int domain;

arch/arm/mm/mmu.c

+6 −1
Original line number Diff line number Diff line
@@ -232,12 +232,16 @@ __setup("noalign", noalign_setup); 
#endif /* ifdef CONFIG_CPU_CP15 / else */



#define PROT_PTE_DEVICE		L_PTE_PRESENT|L_PTE_YOUNG|L_PTE_DIRTY|L_PTE_XN

#define PROT_PTE_S2_DEVICE	PROT_PTE_DEVICE

#define PROT_SECT_DEVICE	PMD_TYPE_SECT|PMD_SECT_AP_WRITE



static struct mem_type mem_types[] = {

	[MT_DEVICE] = {		  /* Strongly ordered / ARMv6 shared device */

		.prot_pte	= PROT_PTE_DEVICE | L_PTE_MT_DEV_SHARED |

				  L_PTE_SHARED,

		.prot_pte_s2	= s2_policy(PROT_PTE_S2_DEVICE) |

				  s2_policy(L_PTE_S2_MT_DEV_SHARED) |

				  L_PTE_SHARED,

		.prot_l1	= PMD_TYPE_TABLE,

		.prot_sect	= PROT_SECT_DEVICE | PMD_SECT_S,

		.domain		= DOMAIN_IO,
@@ -508,7 +512,8 @@ static void __init build_mem_type_table(void) 
	cp = &cache_policies[cachepolicy];

	vecs_pgprot = kern_pgprot = user_pgprot = cp->pte;

	s2_pgprot = cp->pte_s2;

	hyp_device_pgprot = s2_device_pgprot = mem_types[MT_DEVICE].prot_pte;

	hyp_device_pgprot = mem_types[MT_DEVICE].prot_pte;

	s2_device_pgprot = mem_types[MT_DEVICE].prot_pte_s2;



	/*

	 * ARMv6 and above have extended page tables.

CRA Git | Maintained and supported by SUSTech CRA and CCSE