Commit 4d949021 authored Jan 22, 2015 by Brian Foster Committed by Dave Chinner Jan 22, 2015

xfs: remove incorrect error negation in attr_multi ioctl



xfs_compat_attrmulti_by_handle() calls memdup_user() which returns a
negative error code. The error code is negated by the caller and thus
incorrectly converted to a positive error code.

Remove the error negation such that the negative error is passed
correctly back up to userspace.

Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>

parent 97bf6af1

fs/xfs/xfs_ioctl32.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -423,7 +423,7 @@ xfs_compat_attrmulti_by_handle(

		ops = memdup_user(compat_ptr(am_hreq.ops), size);
		if (IS_ERR(ops)) {
		error = -PTR_ERR(ops);
		error = PTR_ERR(ops);
		goto out_dput;
		}

Admin message