Commit 4d8be4bc authored May 27, 2020 by Qiushi Wu Committed by Rafael J. Wysocki May 28, 2020

ACPI: CPPC: Fix reference count leak in acpi_cppc_processor_probe()



kobject_init_and_add() takes reference even when it fails.
If this function returns an error, kobject_put() must be called to
properly clean up the memory associated with the object. Previous
commit "b8eb7183" fixed a similar problem.

Fixes: 158c998e ("ACPI / CPPC: add sysfs support to compute delivered performance")
Signed-off-by: Qiushi Wu <wu000273@umn.edu>
Cc: 4.10+ <stable@vger.kernel.org> # 4.10+
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent 5c447c18

drivers/acpi/cppc_acpi.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -846,6 +846,7 @@ int acpi_cppc_processor_probe(struct acpi_processor *pr)
		"acpi_cppc");
		if (ret) {
		per_cpu(cpc_desc_ptr, pr->id) = NULL;
		kobject_put(&cpc_ptr->kobj);
		goto out_free;
		}

Admin message