Commit 4d8a743c authored Jul 06, 2008 by Linus Torvalds

vsprintf: add infrastructure support for extended '%p' specifiers



This expands the kernel '%p' handling with an arbitrary alphanumberic
specifier extension string immediately following the '%p'.  Right now
it's just being ignored, but the next commit will start adding some
specific pointer type extensions.

NOTE! The reason the extension is appended to the '%p' is to allow
minimal gcc type checking: gcc will still see the '%p' and will check
that the argument passed in is indeed a pointer, and yet will not
complain about the extended information that gcc doesn't understand
about (on the other hand, it also won't actually check that the pointer
type and the extension are compatible).

Alphanumeric characters were chosen because there is no sane existing
use for a string format with a hex pointer representation immediately
followed by alphanumerics (which is what such a format string would have
traditionally resulted in).

Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 78a8bf69

lib/vsprintf.c

+14 −2

Original line number	Diff line number	Diff line
		@@ -511,7 +511,14 @@ static char string(char buf, char end, char s, int field_width, int precisio
		return buf;
		}

		static char pointer(char buf, char end, void ptr, int field_width, int precision, int flags)
		/*
		* Show a '%p' thing. A kernel extension is that the '%p' is followed
		* by an extra set of alphanumeric characters that are extended format
		* specifiers.
		*
		* Right now don't actually handle any such, but we will..
		*/
		static char pointer(const char fmt, char buf, char end, void *ptr, int field_width, int precision, int flags)
		{
		flags \|= SMALL;
		if (field_width == -1) {
		@@ -663,7 +670,12 @@ int vsnprintf(char buf, size_t size, const char fmt, va_list args)
		continue;

		case 'p':
		str = pointer(str, end, va_arg(args, void *), field_width, precision, flags);
		str = pointer(fmt+1, str, end,
		va_arg(args, void *),
		field_width, precision, flags);
		/* Skip all alphanumeric pointer suffixes */
		while (isalnum(fmt[1]))
		fmt++;
		continue;

		case 'n':

Admin message