Commit 4d757c5c authored by Lai Jiangshan's avatar Lai Jiangshan Committed by Tejun Heo
Browse files

workqueue: narrow the protection range of manager_mutex 



In create_worker(), as pool->worker_ida now uses
ida_simple_get()/ida_simple_put() and doesn't require external
synchronization, it doesn't need manager_mutex.

struct worker allocation and kthread allocation are not visible by any
one before attached, so they don't need manager_mutex either.

The above operations are before the attaching operation which attaches
the worker to the pool. Between attaching and starting the worker, the
worker is already attached to the pool, so the cpu hotplug will handle
cpu-binding for the worker correctly and we don't need the
manager_mutex after attaching.

The conclusion is that only the attaching operation needs manager_mutex,
so we narrow the protection section of manager_mutex in create_worker().

Some comments about manager_mutex are removed, because we will rename
it to attach_mutex and add worker_attach_to_pool() later which will be
self-explanatory.

tj: Minor description updates.

Signed-off-by: default avatarLai Jiangshan <laijs@cn.fujitsu.com>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent 7cda9aae

kernel/workqueue.c

+5 −30
Original line number Diff line number Diff line
@@ -1725,8 +1725,6 @@ static struct worker *create_worker(struct worker_pool *pool) 
	int id = -1;

	char id_buf[16];



	lockdep_assert_held(&pool->manager_mutex);



	/* ID is needed to determine kthread name */

	id = ida_simple_get(&pool->worker_ida, 0, 0, GFP_KERNEL);

	if (id < 0)
@@ -1755,6 +1753,8 @@ static struct worker *create_worker(struct worker_pool *pool) 
	/* prevent userland from meddling with cpumask of workqueue workers */

	worker->task->flags |= PF_NO_SETAFFINITY;



	mutex_lock(&pool->manager_mutex);



	/*

	 * set_cpus_allowed_ptr() will fail if the cpumask doesn't have any

	 * online CPUs.  It'll be re-applied when any of the CPUs come up.
@@ -1762,7 +1762,7 @@ static struct worker *create_worker(struct worker_pool *pool) 
	set_cpus_allowed_ptr(worker->task, pool->attrs->cpumask);



	/*

	 * The caller is responsible for ensuring %POOL_DISASSOCIATED

	 * The pool->manager_mutex ensures %POOL_DISASSOCIATED

	 * remains stable across this function.  See the comments above the

	 * flag definition for details.

	 */
@@ -1772,6 +1772,8 @@ static struct worker *create_worker(struct worker_pool *pool) 
	/* successful, attach the worker to the pool */

	list_add_tail(&worker->node, &pool->workers);



	mutex_unlock(&pool->manager_mutex);



	return worker;



fail:
@@ -1809,8 +1811,6 @@ static int create_and_start_worker(struct worker_pool *pool) 
{

	struct worker *worker;



	mutex_lock(&pool->manager_mutex);



	worker = create_worker(pool);

	if (worker) {

		spin_lock_irq(&pool->lock);
@@ -1818,8 +1818,6 @@ static int create_and_start_worker(struct worker_pool *pool) 
		spin_unlock_irq(&pool->lock);

	}



	mutex_unlock(&pool->manager_mutex);



	return worker ? 0 : -ENOMEM;

}
@@ -2019,8 +2017,6 @@ static bool manage_workers(struct worker *worker) 
	bool ret = false;



	/*

	 * Managership is governed by two mutexes - manager_arb and

	 * manager_mutex.  manager_arb handles arbitration of manager role.

	 * Anyone who successfully grabs manager_arb wins the arbitration

	 * and becomes the manager.  mutex_trylock() on pool->manager_arb

	 * failure while holding pool->lock reliably indicates that someone
@@ -2029,33 +2025,12 @@ static bool manage_workers(struct worker *worker) 
	 * grabbing manager_arb is responsible for actually performing

	 * manager duties.  If manager_arb is grabbed and released without

	 * actual management, the pool may stall indefinitely.

	 *

	 * manager_mutex is used for exclusion of actual management

	 * operations.  The holder of manager_mutex can be sure that none

	 * of management operations, including creation and destruction of

	 * workers, won't take place until the mutex is released.  Because

	 * manager_mutex doesn't interfere with manager role arbitration,

	 * it is guaranteed that the pool's management, while may be

	 * delayed, won't be disturbed by someone else grabbing

	 * manager_mutex.

	 */

	if (!mutex_trylock(&pool->manager_arb))

		return ret;



	/*

	 * With manager arbitration won, manager_mutex would be free in

	 * most cases.  trylock first without dropping @pool->lock.

	 */

	if (unlikely(!mutex_trylock(&pool->manager_mutex))) {

		spin_unlock_irq(&pool->lock);

		mutex_lock(&pool->manager_mutex);

		spin_lock_irq(&pool->lock);

		ret = true;

	}



	ret |= maybe_create_worker(pool);



	mutex_unlock(&pool->manager_mutex);

	mutex_unlock(&pool->manager_arb);

	return ret;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE