Commit 4d663649 authored Oct 01, 2019 by Johan Hovold Committed by Marc Kleine-Budde Nov 04, 2019

can: mcba_usb: fix use-after-free on disconnect



The driver was accessing its driver data after having freed it.

Fixes: 51f3baad ("can: mcba_usb: Add support for Microchip CAN BUS Analyzer")
Cc: stable <stable@vger.kernel.org>     # 4.12
Cc: Remigiusz Kołłątaj <remigiusz.kollataj@mobica.com>
Reported-by:  <syzbot+e29b17e5042bbc56fae9@syzkaller.appspotmail.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>

parent fb5be6a7

drivers/net/can/usb/mcba_usb.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -876,9 +876,8 @@ static void mcba_usb_disconnect(struct usb_interface *intf)
		netdev_info(priv->netdev, "device disconnected\n");

		unregister_candev(priv->netdev);
		free_candev(priv->netdev);

		mcba_urb_unlink(priv);
		free_candev(priv->netdev);
		}

		static struct usb_driver mcba_usb_driver = {

Admin message