Commit 4d520f62 authored May 28, 2014 by Ursula Braun Committed by David S. Miller May 30, 2014

af_iucv: correct cleanup if listen backlog is full



In case of transport HIPER a sock struct is allocated for an incoming
connect request. If the backlog queue is full this socket is not
needed, but is left in the list of af_iucv sockets. Final socket
release posts console message "Attempt to release alive iucv socket".
This patch makes sure the new created socket is cleaned up correctly
if the backlog queue is full.

Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com>
Signed-off-by: Frank Blaschka <blaschka@linux.vnet.ibm.com>
Reported-by: Philipp Hachtmann <phacht@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 53a4b499

net/iucv/af_iucv.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -1943,11 +1943,10 @@ static int afiucv_hs_callback_syn(struct sock sk, struct sk_buff skb)
		sk_acceptq_is_full(sk) \|\|
		!nsk) {
		/* error on server socket - connection refused */
		if (nsk)
		sk_free(nsk);
		afiucv_swap_src_dest(skb);
		trans_hdr->flags = AF_IUCV_FLAG_SYN \| AF_IUCV_FLAG_FIN;
		err = dev_queue_xmit(skb);
		iucv_sock_kill(nsk);
		bh_unlock_sock(sk);
		goto out;
		}

Admin message