Commit 4d4f88fa authored by Paul E. McKenney's avatar Paul E. McKenney
Browse files

lockdep: Make RCU suspicious-access splats use pr_err 



This commit switches RCU suspicious-access splats use pr_err()
instead of the current INFO printk()s.  This change makes it easier
to automatically classify splats.

Reported-by: default avatarDmitry Vyukov <dvyukov@google.com>
Signed-off-by: default avatarPaul E. McKenney <paulmck@linux.vnet.ibm.com>
parent 7c6094db

kernel/locking/lockdep.c

+6 −6
Original line number Diff line number Diff line
@@ -4412,13 +4412,13 @@ void lockdep_rcu_suspicious(const char *file, const int line, const char *s) 
#endif /* #ifdef CONFIG_PROVE_RCU_REPEATEDLY */

	/* Note: the following can be executed concurrently, so be careful. */

	printk("\n");

	printk("===============================\n");

	printk("[ INFO: suspicious RCU usage. ]\n");

	pr_err("===============================\n");

	pr_err("[ ERR: suspicious RCU usage.  ]\n");

	print_kernel_ident();

	printk("-------------------------------\n");

	printk("%s:%d %s!\n", file, line, s);

	printk("\nother info that might help us debug this:\n\n");

	printk("\n%srcu_scheduler_active = %d, debug_locks = %d\n",

	pr_err("-------------------------------\n");

	pr_err("%s:%d %s!\n", file, line, s);

	pr_err("\nother info that might help us debug this:\n\n");

	pr_err("\n%srcu_scheduler_active = %d, debug_locks = %d\n",

	       !rcu_lockdep_current_cpu_online()

			? "RCU used illegally from offline CPU!\n"

			: !rcu_is_watching()

CRA Git | Maintained and supported by SUSTech CRA and CCSE