Commit 4d2508a5 authored Mar 15, 2016 by Arnd Bergmann Committed by Dmitry Torokhov Mar 15, 2016

ARM: pxa/raumfeld: use PROPERTY_ENTRY_INTEGER to define props



gcc-6.0 notices that the use of the property_entry in this file that
was recently introduced cannot work right, as we initialize the wrong
field:

raumfeld.c:387:3: error: the address of 'raumfeld_rotary_encoder_steps' will always evaluate as 'true' [-Werror=address]
   DEV_PROP_U32, 1, &raumfeld_rotary_encoder_steps, },
   ^~~~~~~~~~~~
raumfeld.c:389:3: error: the address of 'raumfeld_rotary_encoder_axis' will always evaluate as 'true' [-Werror=address]
   DEV_PROP_U32, 1, &raumfeld_rotary_encoder_axis, },
   ^~~~~~~~~~~~
raumfeld.c:391:3: error: the address of 'raumfeld_rotary_encoder_relative_axis' will always evaluate as 'true' [-Werror=address]
   DEV_PROP_U32, 1, &raumfeld_rotary_encoder_relative_axis, },
   ^~~~~~~~~~~~

The problem appears to stem from relying on an old definition of
'struct property', but it has changed several times since the code
could have last been correct.

This changes the code to use the PROPERTY_ENTRY_INTEGER() macro instead,
which works fine for the current definition and is a safer way of doing
the initialization.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: a9e340dc ("Input: rotary_encoder - move away from platform data structure")
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

parent 245f0db0

arch/arm/mach-pxa/raumfeld.c

+4 −11

Original line number	Diff line number	Diff line
		@@ -378,18 +378,11 @@ static struct gpiod_lookup_table raumfeld_rotary_gpios_table = {
		},
		};

		static u32 raumfeld_rotary_encoder_steps = 24;
		static u32 raumfeld_rotary_encoder_axis = REL_X;
		static u32 raumfeld_rotary_encoder_relative_axis = 1;

		static struct property_entry raumfeld_rotary_properties[] = {
		{ "rotary-encoder,steps-per-period",
		DEV_PROP_U32, 1, &raumfeld_rotary_encoder_steps, },
		{ "linux,axis",
		DEV_PROP_U32, 1, &raumfeld_rotary_encoder_axis, },
		{ "rotary-encoder,relative_axis",
		DEV_PROP_U32, 1, &raumfeld_rotary_encoder_relative_axis, },
		{ NULL }
		PROPERTY_ENTRY_INTEGER("rotary-encoder,steps-per-period", u32, 24),
		PROPERTY_ENTRY_INTEGER("linux,axis", u32, REL_X),
		PROPERTY_ENTRY_INTEGER("rotary-encoder,relative_axis", u32, 1),
		{ },
		};

		static struct property_set raumfeld_rotary_property_set = {

Admin message