Commit 4d23322a authored Dec 13, 2012 by Jiri Olsa Committed by Arnaldo Carvalho de Melo May 28, 2013

perf hists: Rename hist_entry__add_pair arguments



The current logic is to attach pair to the leader hist_entry.

Arguments of hist_entry__add_pair function were placed the other way
round.. driving me crazy.

I.e. list_add_tail expects (new_node, head).

Signed-off-by: Jiri Olsa <jolsa@redhat.com>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1355404152-16523-3-git-send-email-jolsa@redhat.com


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 367c53c0

tools/perf/util/sort.h

+3 −3

Original line number	Diff line number	Diff line
		@@ -117,10 +117,10 @@ static inline struct hist_entry hist_entry__next_pair(struct hist_entry he)
		return NULL;
		}

		static inline void hist_entry__add_pair(struct hist_entry *he,
		struct hist_entry *pair)
		static inline void hist_entry__add_pair(struct hist_entry *pair,
		struct hist_entry *he)
		{
		list_add_tail(&he->pairs.head, &pair->pairs.node);
		list_add_tail(&pair->pairs.node, &he->pairs.head);
		}

		enum sort_mode {

Admin message